[SDK] Feature: ConnectedWalletDetails to use headless UI #5429

kien-ngo · 2024-11-15T06:01:43Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on refactoring the ConnectedWalletDetails component to utilize the AccountProvider for better account management and to prepare for future changes related to the React Native package.

Detailed summary

Updated JSDoc in wallet.ts to indicate future removal.
Replaced ConnectedWalletDetails usage with AccountProvider in ConnectButton.tsx.
Removed useConnectedWalletDetails hook usage in Details.tsx.
Integrated AccountAvatar, AccountBalance, and AccountName components for account details display.
Modified rendering logic for account avatar and name to use new components.
Enhanced balance display using AccountBalance component with improved loading states.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-11-15T06:01:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 5:41am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 5:41am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 5:41am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 5:41am

changeset-bot · 2024-11-15T06:01:47Z

⚠️ No Changeset found

Latest commit: 017b13f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-11-15T06:01:49Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-11-15T06:01:55Z

[React] Feature: Headless UI Token components #5433
[SDK] Feature: ConnectedWalletDetails to use headless UI #5429 👈 (View in Graphite)
[SDK] Feature: Account components #5388
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2024-11-15T06:05:38Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	44.97 KB (0%)	900 ms (0%)	1.8 s (+24.91% 🔺)	2.7 s
thirdweb (cjs)	105.01 KB (0%)	2.2 s (0%)	3 s (+14.75% 🔺)	5.1 s
thirdweb (minimal + tree-shaking)	5.6 KB (0%)	113 ms (0%)	110 ms (+14.49% 🔺)	222 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	97 ms (+157.98% 🔺)	107 ms
thirdweb/react (minimal + tree-shaking)	18.38 KB (0%)	368 ms (0%)	430 ms (+167.48% 🔺)	797 ms

codecov · 2024-11-15T06:22:07Z

Codecov Report

Attention: Patch coverage is 16.34615% with 87 lines in your changes missing coverage. Please review.

Project coverage is 45.59%. Comparing base (3ce5673) to head (22e4d0f).

Files with missing lines	Patch %	Lines
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx	0.00%	72 Missing ⚠️
...b/src/react/web/ui/ConnectWallet/ConnectButton.tsx	53.12%	15 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                    @@
##           kien/account-components    #5429   +/-   ##
========================================================
  Coverage                    45.58%   45.59%           
========================================================
  Files                         1076     1076           
  Lines                        55921    55927    +6     
  Branches                      4061     4058    -3     
========================================================
+ Hits                         25494    25500    +6     
  Misses                       29740    29740           
  Partials                       687      687

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from e0eea33
packages	`40.74% <16.34%> (+<0.01%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
packages/thirdweb/src/react/core/utils/wallet.ts	`4.82% <ø> (ø)`
...b/src/react/web/ui/ConnectWallet/ConnectButton.tsx	`49.01% <53.12%> (+<0.01%)`	⬆️
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx	`1.05% <0.00%> (-0.04%)`	⬇️

... and 5 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

gregfromstl · 2024-11-19T20:59:28Z

changelog

graphite-app · 2024-11-20T05:36:12Z

Merge activity

Nov 20, 12:36 AM EST: A user added this pull request to the Graphite merge queue.
Nov 20, 12:42 AM EST: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on refactoring the wallet connection components in the `thirdweb` package, specifically enhancing the `ConnectButton` and `ConnectedWalletDetails` components by integrating `AccountProvider` and improving the handling of wallet details. ### Detailed summary - Updated JSDoc comment in `useConnectedWalletDetails` to indicate its limited usage. - Wrapped `ConnectedWalletDetails` with `AccountProvider` in `ConnectButtonInner`. - Removed `useConnectedWalletDetails` from `ConnectedWalletDetails`. - Enhanced `ConnectedWalletDetails` to use `AccountAvatar`, `AccountName`, and `AccountBalance` components. - Updated props handling for connected account avatar and name in `ConnectedWalletDetails`. - Refactored balance display logic in `ConnectedWalletDetails` to use `AccountBalance`. - Modified `DetailsModal` to utilize `AccountProvider` and improved wallet avatar handling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

kien-ngo mentioned this pull request Nov 15, 2024

[SDK] Feature: Account components #5388

Merged

github-actions bot added the packages label Nov 15, 2024

kien-ngo changed the title ~~update~~ ConnectedWallet Nov 15, 2024

kien-ngo changed the title ~~ConnectedWallet~~ ConnectedWalletDetails to use headless UI Nov 15, 2024

kien-ngo marked this pull request as ready for review November 15, 2024 06:02

kien-ngo requested review from MananTank, edwardysun, gregfromstl, jnsdls and joaquim-verges as code owners November 15, 2024 06:02

kien-ngo force-pushed the kien/account-components branch from 59a23e4 to cd75491 Compare November 15, 2024 06:05

kien-ngo force-pushed the kien/account-components-in-connect-button branch from b544236 to c5c7dd0 Compare November 15, 2024 06:05

kien-ngo mentioned this pull request Nov 15, 2024

[React] Feature: Headless UI Token components #5433

Merged

gregfromstl changed the title ~~ConnectedWalletDetails to use headless UI~~ [SDK] Feature: ConnectedWalletDetails to use headless UI Nov 15, 2024

gregfromstl assigned kien-ngo Nov 15, 2024

kien-ngo force-pushed the kien/account-components branch from cd75491 to 76da5b5 Compare November 18, 2024 07:21

kien-ngo force-pushed the kien/account-components-in-connect-button branch from c5c7dd0 to 3f95cd6 Compare November 18, 2024 07:21

vercel bot deployed to Preview – wallet-ui November 18, 2024 07:28 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www November 18, 2024 07:30 Failure

vercel bot had a problem deploying to Preview – docs-v2 November 18, 2024 07:30 Failure

vercel bot deployed to Preview – thirdweb_playground November 18, 2024 07:30 View deployment

kien-ngo force-pushed the kien/account-components branch from 76da5b5 to c26de55 Compare November 18, 2024 07:39

kien-ngo force-pushed the kien/account-components-in-connect-button branch from 3f95cd6 to e4bffbf Compare November 18, 2024 07:39

vercel bot deployed to Preview – wallet-ui November 18, 2024 07:50 View deployment

gregfromstl approved these changes Nov 19, 2024

View reviewed changes

joaquim-verges approved these changes Nov 19, 2024

View reviewed changes

graphite-app bot added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 20, 2024

kien-ngo force-pushed the kien/account-components branch from 3ce5673 to c56c615 Compare November 20, 2024 04:38

kien-ngo force-pushed the kien/account-components-in-connect-button branch from 22e4d0f to ac39139 Compare November 20, 2024 04:38

vercel bot deployed to Preview – wallet-ui November 20, 2024 04:45 View deployment

vercel bot deployed to Preview – thirdweb_playground November 20, 2024 04:45 View deployment

vercel bot deployed to Preview – docs-v2 November 20, 2024 04:49 View deployment

kien-ngo force-pushed the kien/account-components branch from c56c615 to fa0f0db Compare November 20, 2024 04:51

kien-ngo force-pushed the kien/account-components-in-connect-button branch from ac39139 to 3a6371b Compare November 20, 2024 04:52

vercel bot deployed to Preview – wallet-ui November 20, 2024 05:00 View deployment

vercel bot deployed to Preview – thirdweb_playground November 20, 2024 05:01 View deployment

vercel bot deployed to Preview – docs-v2 November 20, 2024 05:03 View deployment

vercel bot deployed to Preview – thirdweb-www November 20, 2024 05:06 View deployment

gregfromstl force-pushed the kien/account-components branch from fa0f0db to 901c3a1 Compare November 20, 2024 05:37

gregfromstl force-pushed the kien/account-components-in-connect-button branch from 3a6371b to 017b13f Compare November 20, 2024 05:37

vercel bot deployed to Preview – wallet-ui November 20, 2024 05:39 View deployment

vercel bot deployed to Preview – docs-v2 November 20, 2024 05:39 View deployment

vercel bot deployed to Preview – thirdweb_playground November 20, 2024 05:40 View deployment

Base automatically changed from kien/account-components to main November 20, 2024 05:41

vercel bot deployed to Preview – thirdweb-www November 20, 2024 05:41 View deployment

graphite-app bot merged commit 017b13f into main Nov 20, 2024
26 of 28 checks passed

graphite-app bot deleted the kien/account-components-in-connect-button branch November 20, 2024 05:42

vercel bot deployed to Production – docs-v2 November 20, 2024 05:44 View deployment

vercel bot deployed to Production – wallet-ui November 20, 2024 05:45 View deployment

vercel bot deployed to Production – thirdweb_playground November 20, 2024 05:45 View deployment

vercel bot deployed to Production – thirdweb-www November 20, 2024 05:58 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Feature: ConnectedWalletDetails to use headless UI #5429

[SDK] Feature: ConnectedWalletDetails to use headless UI #5429

Uh oh!

kien-ngo commented Nov 15, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Nov 15, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 15, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 15, 2024

Uh oh!

kien-ngo commented Nov 15, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 15, 2024 •

edited

Loading

Uh oh!

codecov bot commented Nov 15, 2024 •

edited

Loading

Uh oh!

gregfromstl commented Nov 19, 2024

Uh oh!

graphite-app bot commented Nov 20, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[SDK] Feature: ConnectedWalletDetails to use headless UI #5429

[SDK] Feature: ConnectedWalletDetails to use headless UI #5429

Uh oh!

Conversation

kien-ngo commented Nov 15, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

kien-ngo commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gregfromstl commented Nov 19, 2024

Uh oh!

graphite-app bot commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kien-ngo commented Nov 15, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 15, 2024 •

edited

Loading

changeset-bot bot commented Nov 15, 2024 •

edited

Loading

kien-ngo commented Nov 15, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

graphite-app bot commented Nov 20, 2024 •

edited

Loading